Skip to content

chore: fix flaky tests #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 7, 2019
Merged

chore: fix flaky tests #452

merged 10 commits into from
Dec 7, 2019

Conversation

dtopuzov
Copy link
Contributor

@dtopuzov dtopuzov commented Dec 6, 2019 •
edited
Loading

  • Update timeouts
  • Fix values for app size (for 6.3 we include new css parser in modules and new ios webkit also add ~2%)
  • Get host os screenshot on test fail
  • Log trace on some tests to debug flakyness
  • Minor refactoring
  • Fix Travis CI

@cla-bot cla-bot bot added the cla: yes label Dec 6, 2019
@dtopuzov
Copy link
Contributor Author

dtopuzov commented Dec 7, 2019

run core tests

2 similar comments
@dtopuzov
Copy link
Contributor Author

dtopuzov commented Dec 7, 2019

run core tests

@dtopuzov
Copy link
Contributor Author

dtopuzov commented Dec 7, 2019

run core tests

@dtopuzov dtopuzov merged commit 91623db into master Dec 7, 2019
@dtopuzov dtopuzov deleted the fix-flaky-tests branch December 9, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhristov5555 vhristov5555 vhristov5555 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtopuzov @vhristov5555